Burns,
If I recall there may be more than one instance in that code of an unguarded loop.
I’m a bit fuzzy as it’s been a long time since I reviewed the code in full.
Jim McCullers
WA4CWI
Thanks, Jim. I forwarded your assessment to Rich in Golf to look at the loop issue for Golf too.
73,
Burns Fisher, WB1FJ
AMSAT(R) Engineering -- Flight Software
On Wed, Jul 17, 2024 at 6:26 PM Jim McCullers via pacsat-dev <pacsat-dev@amsat.org> wrote:
Chris,
Partially working was your comment in the original assessment.
I did a copy and paste on the subject for continuity.
Jim
Yes, very good. I agree with the suggested software changes. Note that this code comes from GOLF so they should update it too, if they have not already. If only we had common development and a library! Oh well.
You say it is partially working. What part is still broken?
73
Chris
On Wed, Jul 17, 2024, 12:15 Bill Reed via pacsat-dev <pacsat-dev@amsat.org> wrote:
WOW, good work. Good recommendations. Thanks.
On 7/17/2024 10:04 AM, Jim McCullers via pacsat-dev wrote:
See attached.
-----------------------------------------------------------pacsat-dev mailing list -- pacsat-dev@amsat.orgView archives of this mailing list at https://mailman.amsat.org/hyperkitty/list/pacsat-dev@amsat.orgTo unsubscribe send an email to pacsat-dev-leave@amsat.orgManage all of your AMSAT-NA mailing list preferences at https://mailman.amsat.org
-----------------------------------------------------------
pacsat-dev mailing list -- pacsat-dev@amsat.org
View archives of this mailing list at https://mailman.amsat.org/hyperkitty/list/pacsat-dev@amsat.org
To unsubscribe send an email to pacsat-dev-leave@amsat.org
Manage all of your AMSAT-NA mailing list preferences at https://mailman.amsat.org
-----------------------------------------------------------
pacsat-dev mailing list -- pacsat-dev@amsat.org
View archives of this mailing list at https://mailman.amsat.org/hyperkitty/list/pacsat-dev@amsat.org
To unsubscribe send an email to pacsat-dev-leave@amsat.org
Manage all of your AMSAT-NA mailing list preferences at https://mailman.amsat.org